Dan Rose

Results 564 comments of Dan Rose

My impression is that you either inject the effectful code you need as JS callbacks (which is what you’ve done with `wasm_bindgen`) OR you use a runtime adapter that does...

The code is optional in the sense that, if omitted, the connection still gets closed. My reading is that it *should* be sent to indicate the client *intended* to close...

Also, per this spec, if a `WebSocket` object is garbage-collected while open, then no status code is sent. It seems odd to make this the same code as if `close()`...

The interaction with `rules`/`lazy-rules` is also a little unintuitive. Whether or not validation rules are satisfied, the model still gets updated.

> The code for the playground is here: https://github.com/guregu/php/blob/master/www/public_html/trealla.html and I'd be happy to take PRs against it. It's a bit of a mess though, a rough demo at best....

I think this is working as expected. In the playground, I see accessing the `mount` *property* to be deprecated. ![image](https://github.com/user-attachments/assets/52589e7c-3777-490e-984e-5537affa6025) I think instead you want the *call* to be regarded...

There’s a potential here to also add some significant improvements over a two stage JSON-parse then Zod-parse. If you have an error in Zod, the context of that error is...

D'oh! I forgot that `file:` urls are treated differently: > note: Packages linked by local path will not have their own dependencies installed when `npm install` is ran in this...

> This might affect the type compatibility for older TypeScript versions. We have to be careful. is that what `downlevel-dts` and `test/typings-compatibility` are supposed to ensure?

I agree there should be official guidance here. But I think these two suggest different things: - `host.docker.internal` means "Docker hosting the service". I expect this even in non-BlueOS environments....