Dan Rose

Results 564 comments of Dan Rose

There is a great example here https://github.com/ros2/ros2cli/blob/bf4941afd06064d20914c19687a8ca98186687e6/ros2lifecycle/ros2lifecycle/verb/set.py#L86-L89 This utility logs a successful transition to stdout but an unsuccessful one to stderr. So if you're piping the output of the utility,...

And the tests as well to verify tool sanity! I'm sure there are other examples as well across this repo, and it would be a great use case for TDD....

> I think that the idea is to enforce node name uniqueness I think that that's a great idea down the road, and it would obviate this issue. But it's...

Ouch! So RCL doesn’t even *have* a globally unique identifier for nodes?

It may be the same issue. I don't understand `test_linktime_composition.py.in` enough to know whether it's using the launch framework correctly or not.

Some more fixes in https://github.com/101100/nmea-simple/pull/25 to help with ESM. At the very least, we need `dist/index.js` to be marked as using modules. The two approaches are: 1. rename it to...

Fixed? The playground example passes in version 5.3.2.