Rg.Plugins.Popup icon indicating copy to clipboard operation
Rg.Plugins.Popup copied to clipboard

Published 20 hours ago • verified publisher icon rotorgames

[Has]SystemPadding works incorrect on older iOS releases (iOS 11.4)

Open alexpetin opened this issue 3 years ago • 9 comments

🐛 Bug Report

There are several problems different for Android/iOS which depends on plugin version, see below.

Expected behavior

[Has]SystemPadding works correct.

Reproduction steps

Just show a PopupPage and see on system padding.

Configuration

Version: 1.x - 2.x

Platform:

  • [X] :iphone: iOS
  • [X] :robot: Android
  • [ ] :checkered_flag: WPF
  • [ ] :earth_americas: UWP
  • [ ] :apple: MacOS
  • [ ] :tv: tvOS
  • [X] :monkey: Xamarin.Forms

Android.

All plugin versions (checked 1.2.0.223-2.0.0.9) works correct when app in fullscreen mode: image image

But there is problem in split screen mode. OK in landscape: image

But not in portrait: image image

iOS.

Version 1.2.0.223 works OK: image image

Starting version 2.0.0 it works incorrect: image image

alexpetin avatar Dec 16 '20 16:12 alexpetin

Test project with the screens above, just in case. TestPopup.zip

alexpetin avatar Dec 16 '20 17:12 alexpetin

@alexpetin this is probably associated with #500 and #553, I will try and see if I get time to implement the fixes they suggest

LuckyDucko avatar Dec 17 '20 01:12 LuckyDucko

@LuckyDucko Yes, looks the same.

For iOS - please note that this is regression, so maybe just restore related code from version 1.2.0.223?

As for Android - it's really erroneously applied keyboard offset. Just checked - with HasKeyboardOffset="False" it works OK. Moreover it works OK when the app at the bottom of screen: image

alexpetin avatar Dec 17 '20 15:12 alexpetin

@alexpetin it seems this issue with system padding causes other issues (#634) as well. I just haven't found the time to give it a good look at.

LuckyDucko avatar Feb 17 '21 23:02 LuckyDucko

+1

EmmanuelJego avatar Jun 07 '21 13:06 EmmanuelJego

@EmmanuelJego @alexpetin

@rotorgames has done a legend move and potentially sorted this out, could you check this out again?

LuckyDucko avatar Oct 20 '21 02:10 LuckyDucko

@EmmanuelJego @alexpetin

@rotorgames has done a legend move and potentially sorted this out, could you check this out again?

Yes, it works like a charm! 😀 Thanks!

EmmanuelJego avatar Oct 20 '21 07:10 EmmanuelJego

@EmmanuelJego @alexpetin

@rotorgames has done a legend move and potentially sorted this out, could you check this out again?

It works correct on Android and latest iOS, thanks. But there is problem on old iOS: image

alexpetin avatar Oct 20 '21 12:10 alexpetin

I think the issue can be closed because min iOS version available now to simulator is 12.4, where all works correct.

alexpetin avatar Jun 16 '22 16:06 alexpetin