rotki icon indicating copy to clipboard operation
rotki copied to clipboard

WIP: Restructuring blockchain accounts and balances state

Open kelsos opened this issue 3 years ago • 7 comments

Closes #(issue_number)

Checklist

  • [ ] The PR modified the frontend, and updated the user guide to reflect the changes.

kelsos avatar Sep 19 '22 16:09 kelsos

This pull request introduces 10 alerts when merging 078aee7d36f1e6183215bf89e5c7cff3abf55013 into 296d481b6ee05f4e57fb76f551bf3e095ee43c7f - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 19 '22 16:09 lgtm-com[bot]

This pull request introduces 7 alerts when merging 5e52f3828a4dacd97bdbc7fb7470c8c4b05083fb into 296d481b6ee05f4e57fb76f551bf3e095ee43c7f - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 19 '22 17:09 lgtm-com[bot]

This pull request introduces 6 alerts when merging 16f22505c242993bec5733196b5dc006f759d1b4 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 20 '22 13:09 lgtm-com[bot]

This pull request introduces 9 alerts when merging 7f618e2479785cba33f48a81660e0105c99b78a8 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 20 '22 20:09 lgtm-com[bot]

This pull request introduces 6 alerts when merging 71269c121d900d523bbf5b5255ad5564cf5b426c into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 21 '22 08:09 lgtm-com[bot]

This pull request introduces 13 alerts when merging 3af9e4c3ecf5e03574739ba2c7d461376a61a7fe into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 21 '22 12:09 lgtm-com[bot]

This pull request introduces 13 alerts when merging d629530be5c5ac52504d548ea78002988472c295 into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 21 '22 13:09 lgtm-com[bot]

Codecov Report

Merging #4857 (e0048b2) into develop (527cdad) will increase coverage by 0.36%. The diff coverage is 71.88%.

@@             Coverage Diff             @@
##           develop    #4857      +/-   ##
===========================================
+ Coverage    76.79%   77.15%   +0.36%     
===========================================
  Files          806      838      +32     
  Lines        70812    71655     +843     
  Branches      9085     9313     +228     
===========================================
+ Hits         54377    55287     +910     
+ Misses       14944    14877      -67     
  Partials      1491     1491              
Flag Coverage Δ
frontend_integration 58.79% <72.82%> (+0.54%) :arrow_up:
frontend_unit 75.42% <62.42%> (+1.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/dashboard/BlockchainBalanceCardList.vue 88.23% <ø> (+11.76%) :arrow_up:
frontend/app/src/components/helper/NftDetails.vue 0.00% <ø> (ø)
...rontend/app/src/components/helper/PriceRefresh.vue 100.00% <ø> (ø)
...nts/history/ledger-actions/LedgerActionContent.vue 75.71% <ø> (ø)
.../components/settings/api-keys/ExternalServices.vue 100.00% <ø> (ø)
frontend/app/src/plugins/vuetify.ts 100.00% <ø> (ø)
frontend/app/src/premium/premium-apis.ts 15.51% <0.00%> (+0.76%) :arrow_up:
frontend/app/src/services/balances/types.ts 100.00% <ø> (ø)
frontend/app/src/services/rotkehlchen-api.ts 39.22% <ø> (-4.58%) :arrow_down:
frontend/app/src/store/assets/index.ts 35.15% <ø> (-2.58%) :arrow_down:
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 22 '22 17:09 codecov[bot]