rotki icon indicating copy to clipboard operation
rotki copied to clipboard

fix: _consume_uphold_transaction

Open gahrb opened this issue 2 years ago • 4 comments

Closes #(issue_number)

Checklist

  • [ ] The PR modified the frontend, and updated the user guide to reflect the changes.

gahrb avatar Sep 14 '22 13:09 gahrb

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 14 '22 13:09 CLAassistant

Hello @gahrb ! We have a CLA that you would need to sign before contributing to the repo. Can you provide an explanation to the PR to understand the issue?

yabirgb avatar Sep 14 '22 14:09 yabirgb

Thanks @LefterisJP and @yabirgb for getting back this quickly. I'm without my laptop until Tuesday and will get back to you afterwards. Marking it as draft for now.

gahrb avatar Sep 15 '22 10:09 gahrb

Hi @yabirgb & @LefterisJP,

I changed the commit to match your style guides and signed the CLA.

About the pull request:

  • I found the data_import modules to be underrepresented in the tests
  • At the same time they all seem to be doing the same: Take some exchange's export, bring it into rotki's data format and import the data

Since I haven't contributed yet to rotki, I found this a good and easy point of entrance. I picked uphold as an example and added the following changes:

  • Create helper functions that can be used by each exchange's import module
  • Call the corresponding functions (as a first step only) by uphold.

Let me know if this is of help and if the changes lgty. I would then mark the PR as ready.

gahrb avatar Sep 20 '22 12:09 gahrb

This PR has stayed open for too long without any response from the author. Will close it soon if no progress is made.

LefterisJP avatar Dec 27 '22 23:12 LefterisJP

Closing due to inactivity.

LefterisJP avatar Jan 02 '23 09:01 LefterisJP