rotki icon indicating copy to clipboard operation
rotki copied to clipboard

refactor asset classes

Open prettyirrelevant opened this issue 2 years ago • 15 comments

prettyirrelevant avatar Sep 13 '22 07:09 prettyirrelevant

Codecov Report

Merging #4834 (3c00b19) into develop (527cdad) will decrease coverage by 2.94%. The diff coverage is 92.78%.

:exclamation: Current head 3c00b19 differs from pull request most recent head b7d0120. Consider uploading reports for the commit b7d0120 to get more accurate results

@@             Coverage Diff             @@
##           develop    #4834      +/-   ##
===========================================
- Coverage    76.79%   73.84%   -2.95%     
===========================================
  Files          806      781      -25     
  Lines        70812    70816       +4     
  Branches      9085     9025      -60     
===========================================
- Hits         54377    52295    -2082     
- Misses       14944    17044    +2100     
+ Partials      1491     1477      -14     
Flag Coverage Δ
frontend_integration 57.73% <ø> (-0.51%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kehlchen/chain/ethereum/modules/eth2/structures.py 88.81% <50.00%> (ø)
rotkehlchen/exchanges/kraken.py 70.71% <50.00%> (+0.17%) :arrow_up:
rotkehlchen/tasks/manager.py 77.73% <60.00%> (-0.21%) :arrow_down:
rotkehlchen/chain/ethereum/modules/nfts.py 57.24% <66.66%> (ø)
rotkehlchen/chain/manager.py 75.20% <66.66%> (ø)
rotkehlchen/accounting/structures/balance.py 70.40% <75.00%> (ø)
rotkehlchen/assets/asset.py 90.32% <80.26%> (ø)
rotkehlchen/icons.py 54.23% <85.71%> (ø)
rotkehlchen/rotkehlchen.py 84.00% <85.71%> (+1.15%) :arrow_up:
rotkehlchen/accounting/ledger_actions.py 93.75% <100.00%> (ø)
... and 295 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 13 '22 12:09 codecov[bot]

This pull request introduces 6 alerts when merging fceac444501847bacd669d3c476e0ac72f829025 into 671f6361fa00edf0d33d5689ee08f8e84cca62a4 - view on LGTM.com

new alerts:

  • 6 for Wrong name for an argument in a call

lgtm-com[bot] avatar Sep 18 '22 13:09 lgtm-com[bot]

This pull request introduces 6 alerts when merging 8108fec962bea57dfc525db8cd83a01010ba7f3e into 086501ef9b5304f2edfa46f431abec7eb72dc20f - view on LGTM.com

new alerts:

  • 6 for Wrong name for an argument in a call

lgtm-com[bot] avatar Sep 20 '22 09:09 lgtm-com[bot]

This pull request introduces 9 alerts when merging 01244815666aa792fe893fc70805a5ee7e0a2d84 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 6 for Wrong name for an argument in a call
  • 2 for Unused import
  • 1 for Wrong number of arguments in a call

lgtm-com[bot] avatar Sep 20 '22 10:09 lgtm-com[bot]

This pull request introduces 10 alerts when merging 476a78032c7927f0432f71c61213842629bb78f9 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 6 for Wrong name for an argument in a call
  • 3 for Unused import
  • 1 for Wrong number of arguments in a call

lgtm-com[bot] avatar Sep 20 '22 11:09 lgtm-com[bot]

This pull request introduces 79 alerts when merging 1a33f76c8dc3e73ac3553e7120ce5849617921c0 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 63 for Unused import
  • 14 for Module-level cyclic import
  • 2 for Unreachable code

lgtm-com[bot] avatar Sep 20 '22 15:09 lgtm-com[bot]

This pull request introduces 90 alerts when merging b94edbbdd2188799fdb4a4494fad199bfc438708 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 66 for Unused import
  • 18 for Module-level cyclic import
  • 4 for Unused local variable
  • 1 for Unreachable code
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 20 '22 16:09 lgtm-com[bot]

This pull request introduces 88 alerts when merging 126a9331d53ca046b2b558808494702226c3885d into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 69 for Unused import
  • 18 for Module-level cyclic import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 20 '22 16:09 lgtm-com[bot]

This pull request introduces 88 alerts when merging e9d66a1be8b5abfe8a67483cdbc7983f5b365256 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 69 for Unused import
  • 18 for Module-level cyclic import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 20 '22 17:09 lgtm-com[bot]

This pull request introduces 88 alerts when merging 6e01ede5d67b625636a13428a284b5e480ae6c33 into 2cd16daecc07b01a2a3ecb28126a9c9d0deb2816 - view on LGTM.com

new alerts:

  • 69 for Unused import
  • 18 for Module-level cyclic import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 20 '22 18:09 lgtm-com[bot]

This pull request introduces 71 alerts when merging 9ec56464661898a97cce14c809874978e6831d5b into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 69 for Unused import
  • 1 for Unused local variable
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 21 '22 07:09 lgtm-com[bot]

This pull request introduces 73 alerts when merging 1577825d3cb233054607d37ff3cb162e03c6356a into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 72 for Unused import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 21 '22 09:09 lgtm-com[bot]

This pull request introduces 72 alerts when merging c052ca9c3dbd7b09cbe3dae0aee083c824efaa2b into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 71 for Unused import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 21 '22 15:09 lgtm-com[bot]

This pull request introduces 72 alerts when merging 8f7f000c9374c837012aa72251effb96715cd686 into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 71 for Unused import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 21 '22 16:09 lgtm-com[bot]

This pull request introduces 18 alerts when merging a2ede2ea4ea17e3ed58a9430aa3231b693918d6e into 40ba4b80cb71e10a0ee1fd3ae6d7b5166b89a39c - view on LGTM.com

new alerts:

  • 17 for Module-level cyclic import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Sep 21 '22 18:09 lgtm-com[bot]

This pull request introduces 18 alerts when merging 2cf5d693de9536df32ab876c0c96d64a721a9bf4 into 42ac394e6f8d757667ab3da6508fa2b35cdac136 - view on LGTM.com

new alerts:

  • 18 for Module-level cyclic import

lgtm-com[bot] avatar Sep 22 '22 12:09 lgtm-com[bot]

This pull request introduces 3 alerts when merging 62f80dd677e7469788a9375b1f81fd7260143020 into 02d5a148e6fd9f199e3454095d3d9c1f5692705a - view on LGTM.com

new alerts:

  • 3 for Wrong name for an argument in a call

lgtm-com[bot] avatar Sep 22 '22 23:09 lgtm-com[bot]