rotki icon indicating copy to clipboard operation
rotki copied to clipboard

Group NFTs in statistics by collection

Open rkalis opened this issue 4 years ago • 7 comments

Right now every NFT is its own entry in all statistics views, with incomprehensible names (_nft_address_index). Ideally I would see an entry in the statistics saying "Cool Cats" rather than two separate entries saying "_nft_coolcats_address_8970" and "_nft_coolcats_address_8709".

See attached screenshot for what NFT balances currently show up as in the "Value Distribution By Asset" breakdown in the statistics.

Screen Shot 2021-10-04 at 11 43 18

rkalis avatar Oct 04 '21 10:10 rkalis

Showing the name instead of this should be doable. Grouping by collection will probably be harder but perhaps also possible.

LefterisJP avatar Oct 04 '21 10:10 LefterisJP

Showing the name should be easy we can probably also do it for the next patch release

kelsos avatar Oct 04 '21 10:10 kelsos

Collection can also be done frontend in a hacky way as you can see it's the second address after the underscore. But perhaps would make sense to add such groupign filtering in the backend and do that logic in the backend.

LefterisJP avatar Oct 04 '21 10:10 LefterisJP

So is the naming part of this done now? And only thing would be to group them somewhere by type (NFT) in statistics?

LefterisJP avatar Jul 17 '22 07:07 LefterisJP

Naming should work in most of the cases yes

kelsos avatar Jul 18 '22 08:07 kelsos

Naming looks good guys, awesome! Just to be clear, with "grouping" I didn't necessarily mean "NFT" vs "not-NFT", but I'd like to see the aggregate value of e.g. all my Cool Cats under "Cool Cats" rather than "Cool Cat #8970", "Cool Cat #8709", etc. That would make it easier to see at glance how much of my total portfolio is allocated to e.g. Cool Cats. Of course being able to differentiate NFT vs non-NFT would be great as well, but imo less important than group by collection.

Either way it's not a super big deal, so no need to prioritise.

rkalis avatar Jul 20 '22 15:07 rkalis

@LefterisJP for the grouping we probably need to re think the endpoint a bit

kelsos avatar Jul 21 '22 09:07 kelsos