[Enhancement Request] Tiebreaker

[odoyle3114]

Config option to have tiebreaker for weekly winner.

[searnhardt]

Any update on this? I'd like to see this as well.

[randyr505]

I added this to my fork but it doesn't update the weekly winner but it does allow you to entry and keep track of the tiebreakers. I am late starting this year so my fork isn't current on updates. Mainly because my changes never got merged upstream.

[searnhardt]

Thanks Randy. I think I tried installing your fork and had some sort of problems. I’d love to make the changes to the already installed instance if you have a pretty easy task list to follow. I think the DB already has the “ties” portion in it so I’m assuming it would be just a couple of PHP pages that would need to be replaced.

Let me know and I’d love to give it a shot.

Thanks, Sean E

From: Randy Rasmussen [mailto:[email protected]] Sent: Saturday, September 2, 2017 3:58 PM To: rothkj1022/phppickem [email protected] Cc: searnhardt [email protected]; Comment [email protected] Subject: Re: [rothkj1022/phppickem] [Enhancement Request] Tiebreaker (#35)

I added this to my fork but it doesn't update the weekly winner but it does allow you to entry and keep track of the tiebreakers. I am late starting this year so my fork isn't current on updates. Mainly because my changes never got merged upstream.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/rothkj1022/phppickem/issues/35#issuecomment-326766272, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADoqMYIlJ6HNKA5CEotb7zE3VEgsJeinks5sebNHgaJpZM4LsqTS.

[randyr505]

I merged my forked after I posted so you may want to try again. Hopefully it is fixed. If not, let me know and I'll diff the pages to see what all is different. If I recall it wasn't a lot.

Yes, the ties portion is in the db so I didn't have to do anything there I don't think.

[searnhardt]

Thanks Randy. I've changed / merged the pages and everything seems to be showing up correctly, I guess I'll have to wait on a tie to see how it actually works!

[savagegeek]

You can test it with TB vs MIA since that game has been moved to Week 11 now due to Hurricane Irma. You can just set that game to a tie if you like. guess it is up to you.

On September 8, 2017 at 12:42 PM searnhardt [email protected] wrote:

Thanks Randy. I've changed / merged the pages and everything seems to be showing up correctly, I guess I'll have to wait on a tie to see how it actually works!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/rothkj1022/phppickem/issues/35#issuecomment-328154690 , or mute the thread https://github.com/notifications/unsubscribe-auth/AT4d0rpAavEMJYygUThy5iwIDo0wxRIYks5sgW5vgaJpZM4LsqTS .

 

[randyr505]

Sean,

Did you make any changes to allow it to update the winners in the DB? If so, can you create a pull request? I'd like to see the differences. Just to reiterate, mine just allows you to input points and keep track of them.

Savagegeek, he isn't referring to a tie game, he is referring to users having the same number of wins at the end of the week.

[searnhardt]

I didn't make any changes to the code, just implemented the pages you had so that I could see the tiebreaker points. I was guessing / assuming that you might be taking that into consideration on the results page to be able to choose the person with the closest tie-breaker points to show as the winner? And, I guess there could still be a weekly tie if two people choose the same tie-breaker points...