uddup icon indicating copy to clipboard operation
uddup copied to clipboard

Pipe input and concurrent futures

Open DylanTiger opened this issue 1 year ago • 2 comments

  • Now it's possible to use pipe for input. Silent flag will be automatically activated.
  • Implemented concurrent futures and locks to avoid race conditions
  • Implemented batch processing to avoid frequent locks that slow down the script

DylanTiger avatar Oct 11 '24 04:10 DylanTiger

Thanks for the PR @DylanTiger! I'll review it soon.

When I started working on it a while ago I created some unit tests as well, but I never had the time to complete the job.

I think that we must have unit tests for this change and I wonder if you can handle this part as well or should I try to find the time to handle it? I can share the branch I worked on (with the failing tests).. Any chance that

rotemreiss avatar Oct 11 '24 09:10 rotemreiss

OK i may try to check...however i already know that there are little discrepancy using this updated script, probably due to the batch logics. I suppose that if the same url is in 2 different batches, it won't be unduplicated so the results may contain few duplicated urls, if you think that this is a problem i may try to solve it applying a second deduplication on the final result.

DylanTiger avatar Oct 30 '24 09:10 DylanTiger