chef-ruby_install icon indicating copy to clipboard operation
chef-ruby_install copied to clipboard

update to 0.6.1

Open dayne opened this issue 9 years ago • 4 comments

dayne avatar Feb 03 '16 02:02 dayne

I'm not 100% sure but I'm pretty sure you need to update the checksum as well so it matches 0.6.0. I believe 3cc90846ca972d88b601789af2ad9ed0a496447a13cb986a3d74a4de062af37d is the proper checksum.

Were you able to run test kitchen successfully after upping the version? Mine failed, throwing a git error, which I thought was related to install_with_make running make and make install. Specifically make for ruby-install tries to run a git command, which of course won't work because this isn't a git directory.

jasonblalock avatar Mar 30 '16 16:03 jasonblalock

Thanks for the PR @dayne

I would indeed expect the shasum to change too.

Also, this test: https://github.com/rosstimson/chef-ruby_install/blob/master/test/integration/installation/serverspec/installation_spec.rb#L15

rosstimson avatar Mar 30 '16 19:03 rosstimson

Has the reason that this PR not been merged only that the checksum needs to be updated? The current checksum for ruby-install 0.6.0 is 3cc90846ca972d88b601789af2ad9ed0a496447a13cb986a3d74a4de062af37d.

davejlong avatar Jun 02 '16 15:06 davejlong

@rosstimson

Since submitting this pull request I've leveled up on understanding the test kitchen and important that part of a pull request is.

I've come back to this pull request and updated it to 0.6.1, correct checksum, and updated test kitchen environment to ensure this cookbook is still relevant on modern systems and updated rubies.

The installation and partial-ruby-version test suites converge and verify cleanly.

kitchen suite alltherubies converges on older platforms but has issues with rbx and jruby parts. Looking at your README it appears you are aware of this issue. I dug in a bit and it appears ruby-install itself would need to be updated to support modern platforms such as Ubuntu-16.10 to allow for successful building and testing of rbx and jruby.

Thanks

dayne avatar Feb 19 '17 21:02 dayne