Ross Kaffenberger

Results 18 comments of Ross Kaffenberger

The Rails log 404ing on `"/srv/www//current/public/assets/serviceworker-2ed7e64d46b390cd57183ad0bb4105a2a64f6a84923c2c0b47cab0f6f9747b0c.js"` means Rails can't find the file at that path. If you can access the production file system, you could try looking for that file...

@ncs1 Thanks for working on these changes. The main branch is now passing on CircleCI. Would you like to rebase and fix the failing tests on your branch?

Perhaps separate tasks would be the most straightforward? ```rails $ rails g serviceworker:install::sprockets $ rails g serviceworker:install::webpacker ```

I agree it would be nice to omit the baked in defaults if you don't need them. They're included automatically in the engine: https://github.com/rossta/serviceworker-rails/blob/c2ea427b3164df2e237a94aed62259c9b6890192/lib/serviceworker/engine.rb#L18-L2 A PR to omit these files...

I left the existing registered drivers in place, but I found that the more-recent versions of Capybara provide `selenium_chrome` and `selenium_chrome_headless` drivers that may work for you. Aside from that,...

@jejacks0n Just checking in to see if any more changes are needed before this is ready to merge. Thanks!

We are also successfully building with 1.0.0-beta.4 on both React 17 (with the my [documented webpack workaround](https://github.com/renchap/webpacker-react/issues/147)) and React 18 on webpack 5. It would be great to see this...

@renchap I notice that ujs integration hasn't yet been implemented. Would you like some assistance completing this branch?