rossipedia

Results 20 comments of rossipedia

This would require `init.method`, as the default method of `GET` doesn't really make a lot of sense here since it's about specifying the `Content-Type` of the request body.

> If we called shouldRevalidate once and decided we need to call a given loader, and that set of loaders redirects to a new location inclusive of the same loader,...

🥳 I would love to be able to supply entry files (and event `root.tsx`) as a `vite` plugin. We have several apps that use common entries and root routes, abstracting...

For `AsyncLocalStorage` at least, won't something like this do the trick? ```ts const storage = new AsyncLocalStorage(); beforeEach(() => { storage.enterWith(someValue); }); test('foo', async () => { expect(storage.getStore()).not.toBeUndefined(); }); //...

> @rossipedia Sadly that doesn't work since the async context isn't persisted as the same context between beforeEach and test. Either vittest would need to guarantee that or you need...

Actually, running with `--no-isolate` didn't cause issues, but what did was running the `beforeEach` that called `AsyncLocalStorage.enterWith()` inside a `describe` block. `getStore()` just returned `undefined` in that scenario It works...

> Update to the above: the use of a fixture is not required and `enterWith` can be used successfully in a `beforeEach` block provided it is the first `beforeEach` block...

> Instead of making this behavior the default, it should be opt in based. I'm fine with defaults, as long as there are escape hatches. This should 100% be configurable,...

> 4. there don't seem to be any guidelines to help migrate codebases from "legacy throw" to the new paradigm That's because "legacy throw" was never officially supported, and it...

> For example, > > ``` > variant="contained" > sx={{ > color: 'black', > }} > > > Hello > > ``` > > In dark mode, the color will...