aprs-python icon indicating copy to clipboard operation
aprs-python copied to clipboard

Generate Telemetry Unit Labels Function

Open kb1lqc opened this issue 8 years ago • 6 comments

I branched from PR #27 commit to add a Telemetry Unit Label Function. This allows one to add unit labels to APRS telemetry. I checked this operation on APRS-IS.

APRS Specification: image

APRS.fi accepted string test: image

Let me know if this should be rolled into #27 instead. Figured I'd keep the PR's separate for new packets.

kb1lqc avatar Mar 11 '17 19:03 kb1lqc

This PR no longer includes the original units/label code

rossengeorgiev avatar Mar 19 '17 11:03 rossengeorgiev

@rossengeorgiev yeah this branch is broken now with your update to #27. At some point in the near future I can merge your update of my telemetry packet into my other code. Since I have not just #28 telemetry/units but also Parameters, Labels, Equations, and project comments implemented as well should they just all go on one single PR?

kb1lqc avatar Mar 23 '17 07:03 kb1lqc

I need to do some refactoring to make packets fit with how parsing is doing things. I might introduce breaking changes to parsing. I will try find time to figure it out this weekend.

Btw, all the current changes are on the packets branch, bad name I know... might rename it :)

rossengeorgiev avatar Mar 24 '17 08:03 rossengeorgiev

OK @rossengeorgiev , So you know while this branch also has my original telemetry packet format which you updated it also contains my other implemented packets for reference. I'd love to get a PR in for these when I can. Let me know when you figure out your packet structure and I'll update them!

https://github.com/kb1lqc/aprs-python/tree/faradayrfcustombitprojectname

kb1lqc avatar Mar 24 '17 15:03 kb1lqc

@rossengeorgiev checking in on this. Any luck with my previous comment? I'd be happy to do it myself too. If so any idea when these would get into the python module installable with pip?

kb1lqc avatar Apr 25 '17 07:04 kb1lqc

I've been sidetracked by other things. Have you seen whats on the packets branch?

https://github.com/rossengeorgiev/aprs-python/compare/packets

You can parse and generate TelemetryReport, you have classes for generating, PARM and UNIT, just need to figure out EQNS and it should be complete.

rossengeorgiev avatar Apr 25 '17 10:04 rossengeorgiev