Andreas Rossberg comments

Results 957 comments of


                                            Andreas Rossberg

Add WASI_API macro to each API entry point

Could you please provide a proper PR description?

C API: u8 in Rust corresponds to unsigned char* in C

Wouldn't it be more appropriate to fix the typedef for `byte_t` instead?

C API: u8 in Rust corresponds to unsigned char* in C

Yes, confirmed. Thanks. :)

Add a Chromium .clang-format file, and apply it

It could be worse (we don't have many `#if`'s :) ). I can easily live with most of its effects but three issues: 1. It removes the spaces around function...

`vec<T>::make_nt` may not be so helpful

Hm, it would probably make more sense for this to take a const char*. As for use case, byte vectors aren't just used for module binaries, names are the relevant...

feat: `wasm_name_new_from_string*` owns `s`

Oh, ouch. I see there is an inconsistency there. Unfortunately, I think this is the wrong fix. These constructors don't take ownership of the string in the implementation, nor should...

docker build fails in C++ Multi test

It's difficult to debug this remotely, but my guess would be that this somehow runs an old version of V8 that does not support multiple values yet. Can you report...

Add safety checks to several C API functions.

Okay, I think it will help to structure the discussion about this PR a bit. There are parts that are fine, parts that I hope we can find a better...

Add safety checks to several C API functions.

Oops, sorry, wrong button.

Add safety checks to several C API functions.

I'm sorry, I've fallen behind severely on my GH backlog. Will try to catch up on non-quick replies over the course of next week.