Andreas Rossberg

Results 957 comments of Andreas Rossberg

@eqrion, I guess I'm still a bit confused about what exactly the surprise is — when you add a `sub`, you can subtype it further. Why is that not what...

@eqrion, to clarify, "open" and "closed" types are meta-level notions, not features that would arise as keywords. The spec defines – as is common practice and basic standard terminology –...

@titzer, I believe we have already converged on keeping `final`. The open question is about the inverse keyword, and whether we require one at all. For more context, we do...

I think it was adopted by relaxed SIMD tests, so I don't want to lose its correct integration with the threading implementation.

I agree that the import from "mem" should fail – no module is registered under that name on the main thread. But likewise "Mem" shouldn't work either – FWIW, the...

See #219 for the import issue (and others).

Instead of removing the CI status, could you rather update the link? See same file in main repo for what's needed.

I agree that this test makes sense, but it seems a bit one-off. Can you perhaps extend it to a slightly more systematic bunch of tests for branching out of...

Logically, the exnref of a JS exception is a wrapped value. Internally, it could be the unwrapped JS value itself, depending on implementation choices. That is not observable in Wasm....

Yes, `throw_ref` makes sense. Not sure I like `try_table`, however — since the intent is to deprecate the old instructions, I'd rather give those cumbersome (re)names?