Andreas Rossberg
Andreas Rossberg
Given that he proposed it, I'd suggest @zapashcanon also presents it. Happy to review a PR as well. :)
Isn't more detailed testing and more coverage always better?
@sideshowbarker, is there anything missing for merging this?
@sideshowbarker, today CI failed on the publish-to-w3c target for an unrelated PR: https://github.com/WebAssembly/spec/actions/runs/8133065435/job/22233472624?pr=1737 Do you have an idea what the problem could be?
Thanks for looking into it! Now that you mention it, in fact PRs should probably never cause a push to the w3c repo, only actual pushes to the main branch...
Agreed. The tests in unreachable.wast do not currently test for order of effects. There are quite a few tests for stack polymorphism, which are in unreached-[in]valid.wast. Your example above is...
Agree, PRs welcome. ;)
I'd argue this definition of DefaultValue is a bug, because it doesn't match what the core spec defines as default value.
Yes, that's why the `undefined` value is such a broken concept. One shouldn't ever be using it as a first-class thing. Once you assume that's a thing, default arguments of...
What functionality do you need? When you `make wast.js`, you get a library object `WebAssemblyText`, which allows converting between text and binary format. That's currently the only functionality exported to...