Ross Barnowski

Results 296 comments of Ross Barnowski

> Hi folks wave Are there any reasons for the upper pins in the dependencies? We recently added this package to SciPy's doc and it's limiting us. I'd like to...

@OrionSehn there is already a PR open for this issue at #7136 with a fair bit of discussion - perhaps you could take a look at that one and weigh...

@mohamedrezk122 if you have the bandwidth it'd be good to push this one forward as I think there's a clear path to getting this fix in!

> But Paley graphs ain't defined for p non prime. You shouldn't expect normal behavior in such a case. True... but it makes even less sense to introduce artifacts (like...

> Would you happen to know other workarounds? 😅 IMO it's difficult to get a real handle on performance differences when comparing across years worth of development. Python itself has...

No worries, @Rhyd-Lewis - and thanks for the proposal! As mentioned above, the first step will be to fix the style issues: at this point, it's not clear to reviewers...

> As a side note, is there a reason the files are named (test_)structuralholes.py and not (test_)structural_holes.py? I assume to match the module name, which is `structuralholes.py` without the underscore.

IIUC, it seems that the returning `nan` for isolated nodes is agreed upon as the correct, or at least sensible, behavior. So the remaining question is isolated nodes with self-loops....

> They are anchor links, we should just rewrite the URL when a user clicks on sidebar items so you know what IDs they are :) I'm a bit confused...

This is a nice improvement but it doesn't seem to apply to the landing page where there is no sidebar. AFAICT there's still no way to click on/near the `ECOSYSTEM`...