Ross Barnowski

Results 296 comments of Ross Barnowski

> however automatic testing is saying "Your tests failed on CircleCI", and the output isn't making much sense, is there something I forgot to do? No these failures are unrelated....

> Okay. I merged with main but it seems like the issue is still there Oops - sorry about that. I thought we had fixed all of these but it...

> would it be a better strategy to maintain backwards compatibility by either logging warnings instead of raising an exception, or excluding known working attributes like tooltip or label from...

This one's been inactive for awhile... I think the best way to push the discussion forward would be if there were a proposal on how the problem could be fixed....

@DiamondJoseph if you're comfortable doing so, it might be worthwhile to split this into multiple PRs each with a more focused scope. For example, the updates related to the missing...

Thanks @kpetridis24 - a couple tips for this: 1. Go ahead and submit these fixups as their own PR against main instead of adding them to an already-open PR. We...

It looks like the changes I applied in [94bfd4d](https://github.com/networkx/networkx/pull/5972/commits/94bfd4d90a6fc2c03cd06b1a3e95051a47d24f01) were lost, in the latest push - can you look into that @kpetridis24 ? I can re-push them but I just...

FWIW this is still failing when the test suite is run in random order: see #5992 I will put this in anyways as AFAICT it's just a continuation of the...

Yes please feel free to push any other naming suggestions up here - we should just make sure that the public-facing API is settled prior to the 3.0 release[^1] [^1]:...

Closing as this was covered in #5972