Ross A. Baker

Flow type?

2

I noticed the reactive-streams upgrade, and if I'm reading right, this project requires Java 11. This might be of interest on the new fs2: https://github.com/typelevel/fs2/pull/3102

CI for the dev shell

2

It would be nice if this had CI for the dev shell. It would look a lot like [the one in typelevel-nix](https://github.com/typelevel/typelevel-nix/blob/main/.github/workflows/cache.yml), and catch issues like #221.

``` [warn] versionScheme setting is empty; set `ThisBuild / versionScheme := Some("early-semver")`, `Some("semver-spec")` or `Some("pvp")` [warn] so tooling can use it for eviction errors etc - https://www.scala-sbt.org/1.x/docs/Publishing.html ```

We should update it or remove it.

It would be nice to add a documentation site to make this a more real project. The easiest path might be to retrofit @ChristopherDavenport's library.g8.

TextMap typeclasses for Java implementations?

2

Following from #207, would it make sense to have adapters from the Java implementations? Why: - Because we can - There's a wealth of them in the java instrumentation library...

Sure, it's an Otel implementation for Cats-Effect, but why?

Laws for text map type classes?

1

Getter: keys-get consistency: `forAll { (carrier) => keys(carrier).forall(key => get(carrier, key).isDefined)`? Updater: idempotence?: `forAll { (carrier, k, v) => updated(carrier, k, v) === updated(updated(carrier, k, v), k, v)`

The varags notation on the instruments is a nuisance when setting optional values. The Java library filters null values. Maybe we should have Option attribute keys and filter the Nones.