Ross A. Baker
Ross A. Baker
Thanks, @bplommer. This is a great opportunity for anybody who wants to get their hands dirty with cats-parse. Examples abound in the [headers package](https://github.com/http4s/http4s/tree/main/core/src/main/scala/org/http4s/headers), and I will be happy to...
@rcardin That would be wonderful. Both yours and @zmccoy's have an interesting design point: they refer to seconds, which fit nicely as a `FiniteDuration`. But if we use a `FiniteDuration`...
Yes, I think an ADT would be appropriate for the `Access-Control-Max-Age`.
I think `Parser.char('-') ~ Parser.char('1')` can be `Parser.string("-1")`. I doubt it's measurably faster, but it's easier to read and easier to grep. Please don't be afraid to open a draft...
@rcardin, yes, thank you! And I have not forgotten yours or Zach's above. 😓
I'd expect `addSegment("")` to add an empty segment, so it does end in a slash. And calling it again to result in consecutive slashes.
I don't disagree, but it's a little awkward to have an undefaulted param after a defaulted one. Everything would be `Request(uri = ...)`.
The convenience of it is nice, but it brings to the fore an existing model defect: `RequestCookie` accepts arbitrary raw strings, when their alphabet is much more limited. Furthermore, the...
> Would it be too user-unfriendly to expose a Token newtype in the APIs? I have been wondering about this for at least a year without ever writing a PoC....
There's another bug to fix elsewhere, so I don't expect 0.21.8 to be far behind. Am still excited to have this. :smile: