Ross A. Baker
Ross A. Baker
I've been meaning to contribute http4s' for a while. The main thing holding me back was being a bit more rigorous on the testing. The big thing holding me back...
The `charsetPipe` could generate false positives for single byte. You could call `maxCharsPerByte()` on a charset decoder to be sure. Creating scalacheck generators for all the charsets is an important...
Actually, you can come close to deriving the alphabet for an arbitrary charset with `canEncode` from a `CharsetEncoder`. It just returns false negatives for surrogates, which is why there is...
I'm not sure how expensive decoders are to create. You could iterate all available charsets on your JVM, create a decoder, and build a static set from there. I think...
Could also use this in the Applicative instance, I think?
Yes, I think so. It only affects people using aging charsets on an aging JDK with a relatively recent FS2 feature. But for those few, it's a fatal error.
This looks good to me. I share @seratch's question about the visibility change. I am not a macro expert, so I'm relying heavily on the tests still passing with my...
It makes sense when you consider that `halt` is implemented in terms of an exception, but is suprising if you don't know that. I think we could argue "not a...
That looks right. Does this persist through an sbt clean? Are you certain you don't have other Scalatra versions on your class path?
I like the idea, but spring-web seems heavy for HTML escaping. Could we just implement that as a function and not take on more weight?