pdf-php icon indicating copy to clipboard operation
pdf-php copied to clipboard

Adjust full - last line

Open twoSGmbH opened this issue 3 years ago • 6 comments

Hello,

with the commit 00db904dcb7f3c5af394b06e89674555e421e56a you deleted the calculation of the text option "full" for the last line. We think, its a better moving with the deleted calculation. Only adjust full, when 90 percent of the width is used. This is, why we say its a bug. Can you say, why do you deleted this?

Thank you for the reply.

Best regards

twoSGmbH avatar Jun 21 '21 06:06 twoSGmbH

To be honest I could not remember. I was expecting to behave the same as "common text writers" but with my last finding that could be wrong.

So, I think that should than be configurable at least but also get a default value. I will try to investigate some time for this topic

ole1986 avatar Jun 28 '21 17:06 ole1986

Oh, I remember its justified similar to what CSS styles text-align: justify does.

ole1986 avatar Jun 28 '21 17:06 ole1986

Hi,

I think the CSS style text-align: justify is the best option. Its only stretch the line if the current line not the last. This is better than the 80 % calculation. It's the same process as word it have.

Can you integrate this solution? (Without the 80 % calculation)

twoSGmbH avatar Jun 29 '21 14:06 twoSGmbH

to be honest I do not know when I have the chance to focus on this project. But feel free to add a PR. I can quickly review and we are good to go

ole1986 avatar Aug 23 '21 17:08 ole1986

@ole1986 Hope you had a good Christmas! Have you had time to look into this issue? Best, Kevin

kevinsdb avatar Dec 27 '21 18:12 kevinsdb

@kevinsdb unfortunately I did not had the chance yet to get into this

ole1986 avatar Dec 31 '21 11:12 ole1986