rosonaeldred

Results 14 comments of rosonaeldred

@dlinzner-bcs : behrang suggests we write a test checking that the matrices are sufficiently equivalent (and then leave my helper function in brain as-is)

len(Formula(model string)) is not used consistently everywhere, see https://github.com/experimental-design/bofire/blob/7fb596e0968e48c82bb4e64e30bbef9ed1477af4/bofire/strategies/doe/objective.py#L70 ``` self.formula = deepcopy(formula) self.model_terms_string_expression = convert_formula_to_string( domain=domain, formula=formula ) self.n_model_terms = len(list(np.array(formula, dtype=str))) ```

Also concerning https://github.com/experimental-design/bofire/blob/7fb596e0968e48c82bb4e64e30bbef9ed1477af4/bofire/strategies/doe/utils.py#L155-L184

This is more complex than I can handle. Need an assist from @dlinzner-bcs @R-M-Lee @bertiqwerty e.g.