webgme-rosmod icon indicating copy to clipboard operation
webgme-rosmod copied to clipboard

Support for Deployment Visualizing External Node Communications

Open jeholliday opened this issue 6 years ago • 5 comments

Right now, the deployment commsviz only shows the message connections between self defined messages. It would be good if it could also show connections between external messages and external nodes.

jeholliday avatar Mar 31 '18 18:03 jeholliday

Unfortunately we have no model for what topics external nodes pub/sub/provide/require and on what names - we've talked about adding this but there is no real standard way of discovering them - so we'd have to have the user manually make them within the model (which isn't great because it is error prone and increases the development burden for something that's purely viz). That being said, we're still considering it.

finger563 avatar Apr 01 '18 01:04 finger563

@jeholliday we're definitely open to suggestions for how you might want to represent / model such topics / advertisements

finger563 avatar Apr 02 '18 17:04 finger563

I understand how visualizing messages coming from external nodes would be difficult. Having the external nodes in the visualization isn't necessary but external messages would be useful. It appears that even if a ROSMOD defined node is publishing an external message, and then another ROSMOD defined node subscribes to it, that message doesn't show up in the visualization.

jeholliday avatar Apr 04 '18 00:04 jeholliday

That should be as simple as adding the External Message meta type to the valid objects and ptr list in CommVizControl.js, right @finger563 ?

AWatk avatar Apr 04 '18 00:04 AWatk

Yea @dwatkins and @jeholliday that's an easy thing to add - open a separate issue for it and I'll take care of it tomorrow

finger563 avatar Apr 04 '18 03:04 finger563