pygount icon indicating copy to clipboard operation
pygount copied to clipboard

#113 Remove temporary directory in the output of a git analysis

Open ibe-314 opened this issue 1 year ago • 3 comments

When analyzing a remote git repository a temporary folder is created. The output contained the name of this temporary folder. This commit removes the temporary directory from the displayed output path. Therefore, a new dataclass called PathData is introduced to contain the source path and temporary directory information of a path.

Close #113

ibe-314 avatar Jul 13 '24 14:07 ibe-314

Coverage Status

coverage: 95.877% (+0.03%) from 95.848% when pulling acbda7b4447068d8a72e084135efcbc54b1df58d on 113-clean-up-temp-folder-in-output-of-git-analysis into 2cc2c62276d0050988e9851dafbef3239172cb7a on main.

coveralls avatar Jul 13 '24 14:07 coveralls

@ibe-314 Looks good. I wait for #89 to be merged because after that this might need a couple of changes. But I can take care of that.

roskakori avatar Jul 14 '24 08:07 roskakori

@roskakori, I suggest merging this pull request now. I like how it's realized.

Regarding issue #89, I was re-writing it yesterday, I got stuck; and I realized it would be just as easy to re-write it after this pull request is merged.

e-io avatar Aug 19 '24 15:08 e-io

@roskakori What is the status of this PR? Do you still want to wait for #89?

ibe-314 avatar Jan 21 '25 09:01 ibe-314

@roskakori What is the status of this PR? Do you still want to wait for #89?

@roskakori there is no need to wait #89 because I did (almost) nothing there.

I am sure the best strategy is to merge now this PR #113 (carefully made by @ibe-314) without waiting #89. Thank you.

e-io avatar Jan 21 '25 10:01 e-io

Finally got to merging it. 😑

roskakori avatar Mar 04 '25 12:03 roskakori

@ibe-314 Pygount 2.0.0 featuring this issue is finally available from PyPI.

roskakori avatar Mar 16 '25 03:03 roskakori

Cool, thank's for the information.

ibe-314 avatar Mar 16 '25 16:03 ibe-314