alias-free-gan-pytorch icon indicating copy to clipboard operation
alias-free-gan-pytorch copied to clipboard

discard unusable images

Open sidphbot opened this issue 3 years ago • 4 comments

discard unusable images using a try..catch and subsequent length checking

sidphbot avatar Jul 27 '21 02:07 sidphbot

To me, it would maybe make more sense to make sure that your dataset has no broken images before running any training on it, instead of silently failing on those images. I feel like this PR adds a fix to a problem unrelated with alias-free gan, and only related to a specific dataset that should probably be fixed instead, idk 🤷

pabloppp avatar Jul 27 '21 10:07 pabloppp

I think it will be better to specify exceptions if exception handling is needed.

rosinality avatar Jul 27 '21 13:07 rosinality

apologies, I agree it is not related to alias-free-gan. I was just trying to make it easier to run in collab environments while I am doing that myself. it is an awesome repo ! kudos! feel free to reject the pull request, will specify the exceptions today.

sidphbot avatar Jul 27 '21 14:07 sidphbot

As a software developer with 25 years of experience, here's how I see it: If we know about a potential error that may occur, we should treat it. And using try/catch is the obvious choice. So I agree with @sidphbot.

vsemecky avatar Aug 12 '21 13:08 vsemecky