effing-mad icon indicating copy to clipboard operation
effing-mad copied to clipboard

effects macro: Add vis where needed

Open teohhanhui opened this issue 10 months ago • 1 comments

This (properly) allows effects to live in a separate module from the handlers, while using the effects! macro.

TODO:

  • [x] How do we handle tuple struct field visibility to allow pattern matching? If we allow visibility modifiers it sort of breaks the illusion of it being a function signature lol

teohhanhui avatar Apr 02 '24 13:04 teohhanhui

How do we handle tuple struct field visibility to allow pattern matching? If we allow visibility modifiers it sort of breaks the illusion of it being a function signature lol

~~Should we just remove the fn keyword instead?~~ No.

teohhanhui avatar Apr 02 '24 15:04 teohhanhui

/ping @rosefromthedead :see_no_evil:

teohhanhui avatar Jun 19 '24 13:06 teohhanhui

Thanks! There's a bit of churn in here for a small change (namely, maybe_phantom_data has become group_phantom_data_field and group_phantom_data has been introduced, neither of which seem necessary) - please keep these unrelated changes to a minimum or split them into a separate commit to make the body of the PR easier to review.

LGTM though :)

rosefromthedead avatar Jun 30 '24 12:06 rosefromthedead