vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Missing syntax highlighting in Polyglot Notebook extension

Open akselkvitberg opened this issue 2 years ago • 5 comments

Syntax highlighting in polyglot notebooks are broken after the November update.

This is how a snippet looks in the default theme image image

This is how a snippet looks with Rosé Pine image image

Jupyter notebooks using python seems to be working fine. This is just affecting polyglot notebooks with C#, F# and Powershell.

akselkvitberg avatar Dec 10 '22 14:12 akselkvitberg

Honestly I'm not sure how to reproduce this as I have no experience with using notebooks but if notebooks are a shareable file and you can provide an example file of this happening I'll take a look :)

mvllow avatar Dec 27 '22 19:12 mvllow

See here for an example covering some of the usual syntaxes https://gist.github.com/akselkvitberg/d81d727ed948458c5ea959b81deaaf7d

akselkvitberg avatar Dec 29 '22 20:12 akselkvitberg

I have same problem. Polyglot Notebooks Version: v1.0.4102020

Version: 1.75.0 (user setup)
Commit: e2816fe719a4026ffa1ee0189dc89bdfdbafb164
Date: 2023-02-01T15:23:45.584Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

image

netcore-jroger avatar Feb 03 '23 13:02 netcore-jroger

I found the solution. The theme does not enable semantic highlighting by default, so it needs to be enabled manually in the settings. "editor.semanticHighlighting.enabled": true image image image

I regard this as solved, but perhaps semantic highlighting should be enabled by the theme?

akselkvitberg avatar Jun 17 '23 09:06 akselkvitberg

Good find! I wouldn’t mind enabling it in the theme but some values may need tweaked. Happy to look at this soon but if anyone notices weird or poor highlighting with semantic enabled please post screenshots here :)

mvllow avatar Jun 17 '23 11:06 mvllow