ros2cli
ros2cli copied to clipboard
Hz verb: Warn users about wrong reported freq
I think enough users have wasted time with this tool and I hope to be the last one.
https://github.com/ros2/ros2cli/issues/871 https://github.com/ros2/ros2cli/issues/843 https://robotics.stackexchange.com/questions/95613/ros2-topic-hz-provides-wrong-rate-for-larger-msgs
Please notify me if that modification is ok for you and I'll fix the tests
I'm all in for improving the tool but until the problems are fixed warning the users is the least we can do.
@VictorLamoine could you add QoS improvement in this PR?
I've added this to discuss to the next ROS 2 PMC meeting.
https://github.com/ros2/ros2cli/pull/935 is adding the QoS argument for ros2 topic hz.
@VictorLamoine could you add QoS improvement in this PR?
this has been addressed by https://github.com/ros2/ros2cli/pull/970
Sorry; I didn't have time to deal with this. Well test again and report!
This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-pmc-minutes-for-2025-03-12/42493/1
@VictorLamoine can you close this one, instead i will come up with documentation described in https://github.com/ros2/ros2cli/issues/843#issuecomment-2716401376. if you can review, that would be appreciated.