ros2cli icon indicating copy to clipboard operation
ros2cli copied to clipboard

Hz verb: Warn users about wrong reported freq

Open VictorLamoine opened this issue 9 months ago • 2 comments

I think enough users have wasted time with this tool and I hope to be the last one.

https://github.com/ros2/ros2cli/issues/871 https://github.com/ros2/ros2cli/issues/843 https://robotics.stackexchange.com/questions/95613/ros2-topic-hz-provides-wrong-rate-for-larger-msgs

Please notify me if that modification is ok for you and I'll fix the tests

VictorLamoine avatar Feb 07 '25 09:02 VictorLamoine

I'm all in for improving the tool but until the problems are fixed warning the users is the least we can do.

VictorLamoine avatar Feb 16 '25 13:02 VictorLamoine

@VictorLamoine could you add QoS improvement in this PR?

fujitatomoya avatar Feb 16 '25 20:02 fujitatomoya

I've added this to discuss to the next ROS 2 PMC meeting.

audrow avatar Feb 27 '25 18:02 audrow

https://github.com/ros2/ros2cli/pull/935 is adding the QoS argument for ros2 topic hz.

fujitatomoya avatar Feb 27 '25 18:02 fujitatomoya

@VictorLamoine could you add QoS improvement in this PR?

this has been addressed by https://github.com/ros2/ros2cli/pull/970

fujitatomoya avatar Mar 12 '25 04:03 fujitatomoya

Sorry; I didn't have time to deal with this. Well test again and report!

VictorLamoine avatar Mar 12 '25 12:03 VictorLamoine

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-minutes-for-2025-03-12/42493/1

ros-discourse avatar Mar 12 '25 15:03 ros-discourse

@VictorLamoine can you close this one, instead i will come up with documentation described in https://github.com/ros2/ros2cli/issues/843#issuecomment-2716401376. if you can review, that would be appreciated.

fujitatomoya avatar Mar 12 '25 15:03 fujitatomoya