ros2_documentation
ros2_documentation copied to clipboard
ros2
Update Visualizing ROS 2 data with Foxglove
The current how-to guide for Foxglove with ROS 2 is outdated and contains multiple factual inaccuracies. Updating to correct.
I hit the CI for you and did a cursory review. I didn't see anything wrong with the update itself.
One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location. I believe the original file may pre-date that recedent. If we're updating this doc we should update the location as well. @clalancette @fujitatomoya do you have any thoughts with regard to this?
One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location.
i think this is good idea.
@banisadr btw, awesome gundom picture, i love that.
One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location. I believe the original file may pre-date that recedent. If we're updating this doc we should update the location as well. @clalancette @fujitatomoya do you have any thoughts with regard to this?
Yeah, I actually agree that we should move this to the "Related Projects" part of the site, because it is not part of the core. So @banisadr please do that as well.
Thanks @fujitatomoya @clalancette @kscottz! I moved it over to related projects and did a local test build. Nav/ToC seem to be working. Let me know if there's anything else I should update.
Looks like everything passes and all requests have been addressed. I'll go ahead and merge this. Thanks for being patient while we were all at ROSCon.