rclpy icon indicating copy to clipboard operation
rclpy copied to clipboard

Make Optional things Optional

Open ihasdapie opened this issue 3 years ago • 2 comments

I combed through all 154 matches of = None in the codebase and made Optional things, well, Optional

Signed-off-by: Brian Chen [email protected]

ihasdapie avatar Jul 20 '22 00:07 ihasdapie

I'Il be adding to this PR until mypy is happy and help would be appreciated :)

This is a great effort! May I suggest doing this a few files or a few classes at a time? It's easier for us maintainers to review and merge a little bit at a time than to review a lot all at once. It will also mean you have fewer merge conflicts to deal with as other PRs go in.

sloretz avatar Jul 20 '22 16:07 sloretz

+1 great effort 👍

fujitatomoya avatar Jul 25 '22 06:07 fujitatomoya

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar May 22 '23 17:05 clalancette