rclpy icon indicating copy to clipboard operation
rclpy copied to clipboard

ReadtheDocs page is missing a lot of documentation for API.

Open guzman109 opened this issue 1 year ago • 8 comments

No Node API's found or even a link where to find them.

guzman109 avatar Nov 16 '23 20:11 guzman109

Sorry, can you be more clear about what link you are looking at?

clalancette avatar Nov 16 '23 20:11 clalancette

I went to the one for iron. https://docs.ros.org/en/iron/p/rclpy/api/node.html

guzman109 avatar Nov 16 '23 20:11 guzman109

https://docs.ros.org/en/iron/API-Docs.html

Also, there was no easy way of finding the python docs either, since they were not posted on here.

guzman109 avatar Nov 16 '23 20:11 guzman109

Also, there was no easy way of finding the python docs either, since they were not posted on here.

That page is not meant to be a listing of all documentation. The correct way to find the API docs is through https://index.ros.org, and doing a search for the package you are interested in. In this case, it would lead to https://index.ros.org/p/rclpy/github-ros2-rclpy/#iron, and there is a link to API Docs there.

clalancette avatar Nov 17 '23 13:11 clalancette

Following the links from index.ros.org I get to the same page https://docs.ros.org/en/iron/p/rclpy/api/node.html, which seems to have no content for the Node class.

Comparing a page that does have content with one that doesn't work; the content looks about the same to me:

  • https://github.com/ros2/rclpy/blob/iron/rclpy/docs/source/api/timers.rst
  • https://github.com/ros2/rclpy/blob/iron/rclpy/docs/source/api/node.rst

Seems like the rclpy.node module (and others) fails to be imported in the doc job

https://build.ros2.org/job/Idoc__rclpy__ubuntu_jammy_amd64/11/console

03:53:33 WARNING: Failed to import rclpy.node.
03:53:33 Possible hints:
03:53:33 * AttributeError: module 'rclpy' has no attribute 'node'
03:53:33 * ModuleNotFoundError: No module named 'type_description_interfaces'

sloretz avatar Nov 17 '23 19:11 sloretz

This issue is still happening today (e.g. at http://docs.ros.org/en/jazzy/p/rclpy/ most entries are pretty much empty).

Building the docs locally from source as described in the package readme worked fine.

dghw avatar Jul 19 '24 08:07 dghw

@dghw thanks for checking on this, i also confirmed that local build just works. (many warnings came up though...)

image

@sloretz i have no idea how often this doc CI runs, do you have any idea about this documentation build CI? CC: @clalancette

fujitatomoya avatar Jul 21 '24 13:07 fujitatomoya

Linking https://github.com/ros-infrastructure/rosdoc2/issues/68

sloretz avatar Aug 09 '24 18:08 sloretz