rclpy icon indicating copy to clipboard operation
rclpy copied to clipboard

Timer documentation is missing

Open nstiurca opened this issue 1 year ago • 8 comments

Bug report

Required Info:

  • Operating System: N/A
  • Installation type: N/A
  • Version or commit hash: 0.6.1
  • DDS implementation: N/A
  • Client library (if applicable): rclpy

Steps to reproduce issue

Go to https://docs.ros2.org/dashing/api/rclpy/api/timers.html

Expected behavior

See actual documentation

Actual behavior

See only documentation stub

nstiurca avatar Sep 08 '23 15:09 nstiurca

That documentation is very old; the modern documentation is at https://docs.ros.org/en/rolling/p/rclpy/ , and the class you are interested in particular is in https://docs.ros.org/en/rolling/p/rclpy/rclpy.timer.html#rclpy.timer.Timer.is_canceled .

That said, this is a good reminder that I need to decommission https://docs.ros2.org, so I'll make sure to put that on the TODO list.

clalancette avatar Sep 08 '23 16:09 clalancette

BTW, there is no documentation for rclpy in the humble version of the docs.

there is https://docs.ros.org/en/rolling/p/rclpy/ but not https://docs.ros.org/en/humble/p/rclpy/

Why is that the case?

ZeinBarhoum avatar Sep 12 '23 18:09 ZeinBarhoum

Why is that the case?

We had to do some changes to the underlying code, configuration, and tooling, to get rclpy documentation generation working for Iron. It might be possible to backport that to Humble, but nobody has attempted it.

clalancette avatar Sep 12 '23 18:09 clalancette

Ok, thanks for the explanation

ZeinBarhoum avatar Sep 12 '23 18:09 ZeinBarhoum

That documentation is very old; the modern documentation is at https://docs.ros.org/en/rolling/p/rclpy/ , and the class you are interested in particular is in https://docs.ros.org/en/rolling/p/rclpy/rclpy.timer.html#rclpy.timer.Timer.is_canceled .

Fair, but even so the documentation is quite minimal/stubbed in the updated docs.

nstiurca avatar Sep 20 '23 19:09 nstiurca

That said, this is a good reminder that I need to decommission https://docs.ros2.org/, so I'll make sure to put that on the TODO list.

And yeah I just went off whatever search result I got first. Frustrating to get old info in a case like this.

nstiurca avatar Sep 20 '23 19:09 nstiurca

The 'Node' documentation isn't showing up for me on the modern site either for Iron or Rolling.

https://docs.ros.org/en/iron/p/rclpy/api/node.html https://docs.ros.org/en/rolling/p/rclpy/api/node.html

The 'Subscription' page explicitly points people towards the Node documentation

Users should not create a subscription with this constructor, instead they should call Node.create_subscription().

so it feels like there should be something here.

dghw avatar Oct 26 '23 09:10 dghw