Add TakerSubscription

Open harrisonmg opened this issue 5 months ago • 2 comments

I took a shot at implementing the API discussed in #493.

I didn't implement the take_with method that was previously discussed because rcl_take copies the new message into an RmwMessage, not a Message. It is not obvious to me how to avoid constructing a new Message when converting from RmwMessage to Message via from_rmw_message.

Jul 30 '25 21:07 harrisonmg

@harrisonmg thanks for your contribution. Is this PR ready for review? If not, could you move this to a draft and let us know when it's ready? Thanks

Aug 01 '25 19:08 esteve

@harrisonmg thanks for your contribution. Is this PR ready for review? If not, could you move this to a draft and let us know when it's ready? Thanks

Unless anybody has comments on the API itself, I think it's ready for review.

Sorry if I spammed CI notifications while I tried to fix those tests.

Aug 01 '25 20:08 harrisonmg