ros2_java icon indicating copy to clipboard operation
ros2_java copied to clipboard

Consider renaming rclJavaInit()

Open DongheeYe opened this issue 5 years ago • 1 comments

Hi,

When I use the RCLJava Interfaces, I have a doubt about rclJavaInit API.

There are several APIs with simple verb name.

public static boolean isInitialized()
public static boolean ok()
public static void spin(final Node node)
public static void shutdown()

However, initialization API name is something different.

public static void rclJavaInit()

rclJavaInit() is used with shutdown() in pair. In my short thought, init() is more natural. :) Is there any reason to use specific name like rclJavaInit()?

DongheeYe avatar Feb 21 '20 07:02 DongheeYe

I don't know why it is named rclJavaInit, I agree that init is more idiomatic and would support changing it.

jacobperron avatar Mar 16 '20 19:03 jacobperron