collada_urdf
collada_urdf copied to clipboard
Fix assimp not found on some systems leading to nonsensical inclusion
Attempted fix #43, seems to work AFAIK, but please review.
Weird, I am on Focal... It works fine here. I'm not sure what's going on in the test output... Something about packages not being found?
20:18:49 [rospack] Error: package 'pr2_description' not found
20:18:49 [rospack] Error: package 'pr2_description' not found
That's actually not the warning; that is expected to happen. The warning is here: https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/3/cmake/
Oh hold on... Whoops, left in my debug statements.
Makes me wonder why the other tests passed at all.
not sure why pr2_description is not found, but it is released Aug 2020 https://github.com/ros/rosdistro/pull/26154
I think we need this PR to solve https://github.com/ros/collada_urdf/issues/43
@ros-pull-request-builder retest this please
@clalancette it is strange, the test on ros build farm was passed as follows (https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/5/)
The warning comes from CMake but it is cause by assimp https://build.ros.org/job/Npr__collada_urdf__ubuntu_focal_amd64/5/console
06:58:43 CMake Warning (dev) at /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimpTargets.cmake:54 (if):
06:58:43 if given arguments:
06:58:43
06:58:43 "ON"
06:58:43
06:58:43 An argument named "ON" appears in a conditional statement. Policy CMP0012
06:58:43 is not set: if() recognizes numbers and boolean constants. Run "cmake
06:58:43 --help-policy CMP0012" for policy details. Use the cmake_policy command to
06:58:43 set the policy and suppress this warning.
06:58:43 Call Stack (most recent call first):
06:58:43 /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimp-config.cmake:1 (include)
06:58:43 CMakeLists.txt:16 (find_package)
06:58:43 This warning is for project developers. Use -Wno-dev to suppress it.
06:58:43
06:58:43 -- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.71.0/BoostConfig.cmake (found version "1.71.0") found components: system filesystem program_options
@clalancette or we adopt #46
@ros-pull-request-builder retest this please
Kindly ping. Do you have any plans to merge and release this bug fix?