Possible fix for #506

[orensbruli]

https://github.com/ros-tooling/setup-ros/issues/506

[codecov[bot]]

Codecov Report

Merging #507 (9c39e36) into master (e5c1d12) will decrease coverage by 1.15%. The diff coverage is n/a.

:exclamation: Current head 9c39e36 differs from pull request most recent head 710df4f. Consider uploading reports for the commit 710df4f to get more accurate results

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   93.06%   91.90%   -1.16%     
==========================================
  Files           8        8              
  Lines         173      173              
  Branches       16       16              
==========================================
- Hits          161      159       -2     
- Misses         12       14       +2     

Impacted Files	Coverage Δ
src/package_manager/apt.ts	93.75% <ø> (ø)
src/setup-ros-linux.ts	92.85% <0.00%> (-4.77%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[christophebedard]

Ideally, we wouldn't need to install an older version of libc++-dev (12 vs 14) for all users of setup-ros on Jammy. But, as you mentioned in the issue, libc++* is not included in a clean ros:humble image. Perhaps we could just remove it from setup-ros and let people install it manually if they actually need/use it (e.g., after setup-ros and before action-ros-ci).

[orensbruli]

Ideally, we wouldn't need to install an older version of libc++-dev (12 vs 14) for all users of setup-ros on Jammy. But, as you mentioned in the issue, libc++* is not included in a clean ros:humble image. Perhaps we could just remove it from setup-ros and let people install it manually if they actually need/use it (e.g., after setup-ros and before action-ros-ci).

I agree. I have modified the PR to just not install libc++* for jammy but keep installing for the previous ubuntu versions, that would avoid breaking setup-ros for actions that are already using it, right?

[christophebedard]

I'll tag and release this asv0.4 later today.

Done.