moveit2
moveit2 copied to clipboard
PR about potential missing *2 in FloatingjointModel::distanceRotation
Description
See Issue #1528
I have only added a failing test case corresponding to the issue and created this PR to add any possible fixes, do not merge yet.
Checklist
- [ ] Required by CI: Code is auto formatted using clang-format
- [ ] Extend the tutorials / documentation reference
- [ ] Document API changes relevant to the user in the MIGRATION.md notes
- [x] Create tests, which fail without this PR reference
- [ ] Include a screenshot if changing a GUI
- [ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers
Codecov Report
Merging #1529 (03558e5) into main (066e862) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
:exclamation: Current head 03558e5 differs from pull request most recent head f9cf2b6. Consider uploading reports for the commit f9cf2b6 to get more accurate results
@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
- Coverage 51.15% 51.12% -0.03%
==========================================
Files 380 380
Lines 31758 31758
==========================================
- Hits 16242 16232 -10
- Misses 15516 15526 +10
Impacted Files | Coverage Δ | |
---|---|---|
...veit_core/robot_model/src/floating_joint_model.cpp | 60.21% <100.00%> (ø) |
|
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp | 73.46% <0.00%> (-3.70%) |
:arrow_down: |
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp | 75.36% <0.00%> (-1.07%) |
:arrow_down: |
moveit_core/robot_state/src/robot_state.cpp | 47.37% <0.00%> (-0.07%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request is in conflict. Could you fix it @werner291?
This pull request is in conflict. Could you fix it @werner291?
This PR looks like it has conflicts, is over a year old, and is unfinished. I love the approach of adding a failing test case before fixing an issue and feel free to re-open this.