navigation2 icon indicating copy to clipboard operation
navigation2 copied to clipboard

[binary filter] change boolean ros params

Open enricosutera opened this issue 1 year ago • 11 comments

Basic Info

Info Please fill out this column
Ticket(s) this addresses https://github.com/ros-planning/navigation2/issues/3511#
Primary OS tested on Ubuntu 22.04, Rolling (debian)
Robotic platform tested on None

Description of contribution in a few bullet points

  • The binary filter is now able to change boolean ros parameters using a service. The parameters can be changed accordingly to filter binary value or opposite to it (this can be specified for each parameter).

Description of documentation updates required from your changes

  • Added new parameters for the binary filters, documentation (https://github.com/ros-planning/navigation.ros.org/pull/460)

Future work that may be required in bullet points

  • Not required, but an extension or another filter could be developed to change also double parameters dynamically.

For Maintainers:

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

enricosutera avatar Sep 05 '23 17:09 enricosutera