navigation2 icon indicating copy to clipboard operation
navigation2 copied to clipboard

Log display time taken waypoints

Open Ryanf55 opened this issue 2 years ago • 45 comments


Basic Info

Info Please fill out this column
Display elapsed time in RVIZ panel and add time logging #3347
Primary OS tested on Ubuntu 22.04

Description of contribution in a few bullet points

  • I added two new fields in the waypoint follower action for time logging
  • I fixed a typo for a random field that was defined wrong
  • I added a field to the RVIZ panel to display total elapsed time -->

Description of documentation updates required from your changes

  • Added description of additional time reporting fields in the nav2_waypoint_follower

Future work that may be required in bullet points

  • Display current waypoint number and current loop count in RVIZ
  • Display of the result.wp_elapsed_time as a table in RVIZ

TODO list before merge

  • [ ] Propose message contents have comments explaining the usage of the fields
  • [ ] Add some unit tests in thenav2_waypoint_follower package
  • [x] Properly handle end of waypoint mission setting time to zero
  • [x] Decide if the total elapsed time field should not appear if not in waypoint follow mode
  • [x] Convert to QTableWidget and make the UI look nearly the same as before
  • [x] Handle hiding/showing UI items dynamically like before, but with QTableWidget
  • [x] Investigate if calling new every render is a bad idea for the table elements

For Maintainers:

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Ryanf55 avatar Jan 25 '23 16:01 Ryanf55