velodyne
velodyne copied to clipboard
Sync master
Note:
- https://github.com/ros-drivers/velodyne/commit/5206c95148c02abad71854d76adb52ec8c85f569
- https://github.com/ros-drivers/velodyne/commit/3f11fab5f9a8d0774e566d63f1e6bbe9d7519341 -> drop. A part of this commit is already fixed in
ros2
. Another part shoud be fixed after parameter callback is implemented. - https://github.com/ros-drivers/velodyne/commit/0fc1aebbceef4ae8ceaf233267589e669fddef06 -> drop. already removed.
- https://github.com/ros-drivers/velodyne/commit/0737cf077537ee7ddfa1d7771d22f759277ed74b
- https://github.com/ros-drivers/velodyne/commit/96b39056bc16c5d3be9d32a709d4cd824189ef40 -> drop. already fixed.
- https://github.com/ros-drivers/velodyne/commit/d3f85646503aa72a70aafab6ac757c36aa3ff1c2
- https://github.com/ros-drivers/velodyne/commit/f028b5972c8a179b951117a42eac69e0505a665d -> drop. unnecessary for
ros2
- https://github.com/ros-drivers/velodyne/commit/720829573076bf7d7edd4b1de344924fad909049 -> drop. A poll thread is implemented in
ros2
.
@clalancette @JWhitleyWork I appreciate it if you could review this. Have a great holidays.
@wep21 I have to say that this is a difficult PR to review. The changes are just so all over the place.
It would be much easier for me to review if it was split up into smaller, more logical chunks. Maybe one or a handful of commits per PR. That way we could look at the code and the CI for each of them.