nmea_navsat_driver icon indicating copy to clipboard operation
nmea_navsat_driver copied to clipboard

Published 20 hours ago • verified publisher icon ros-drivers

[bug] Using UDP communication, some statements fail to match because line breaks are not cleanly filtered.

Open zymouse opened this issue 1 year ago • 4 comments

settled

  • [x] brach: ros2
  • [x] commit: 861323c
  • [x] Already read the document
  • [x] Debugging the code to make sure it's a code bug
  • [x] Tested TCP and UDP against each other: no problems with TCP, problems with UDP line breaks `\r
  • [x] Grab packets via wireshark:
    • [x] Make sure there are no problems with the data
    • [x] Determine that TCP and UDP are receiving the same data image

Description of the problem

UDP test: match failed because a statement line break was not filtered cleanly

https://github.com/ros-drivers/nmea_navsat_driver/blob/b168f499349e5f26e3aed9982deb44ed2f41f8e2/src/libnmea_navsat_driver/parser.py#L288

image

Possible causes

https://github.com/ros-drivers/nmea_navsat_driver/blob/861323c83c04ca02454187c85528ddca9a7ef94d/src/libnmea_navsat_driver/nodes/nmea_socket_driver.py#L81

zymouse avatar Dec 14 '23 10:12 zymouse