nmea_navsat_driver icon indicating copy to clipboard operation
nmea_navsat_driver copied to clipboard

Published 20 hours ago • verified publisher icon ros-drivers

Add Support for TCP GNSS Sensor

Open BerndSchmecka opened this issue 2 years ago • 1 comments

I added a new nmea_tcpclient_driver, because Sensors like the Emlid Reach RS2 do not offer any UDP connection, but transmit NMEA-Sentences on Port 9001/tcp. The nmea_tcpclient_driver connects to it via TCP and forwards the NMEA-Sentences line by line to the driver.

PS: Sorry about the commit-Messages, got a little exhausted during debugging ;)

BerndSchmecka avatar Jul 15 '22 19:07 BerndSchmecka

Thanks for the contribution. I'll review the PR soon!

evenator avatar Jul 16 '22 20:07 evenator

Also, I'm sorry it took so long for me to review this. Maintaining this package is a side hobby for me, and it often gets away from me.

evenator avatar Nov 15 '22 18:11 evenator

I'm sorry it took so long for me to review this. Maintaining this package is a side hobby for me, and it often gets away from me.

No problem, I appreciate that you use your free time for maintaining this. It has been really useful for me during a project for university.

I have some requests and suggestions. Thanks for the PR!

I now implemented those changes.

BerndSchmecka avatar Nov 15 '22 19:11 BerndSchmecka

Reverted the change

BerndSchmecka avatar Nov 17 '22 11:11 BerndSchmecka