gscam icon indicating copy to clipboard operation
gscam copied to clipboard

Replace build and run depend of opencv2 with opencv3.

Open robograffitti opened this issue 8 years ago • 5 comments

rosdep install gscam does not work because ros-indigo-opencv2 is deprecated.

Insread, ros-indigo-opencv3 is available, so I replaced opencv2 with opencv3 in package.xml.

robograffitti avatar Jul 14 '16 09:07 robograffitti

To which ROS versions should this apply?

Which are not compatible?

jack-oquin avatar Jul 14 '16 14:07 jack-oquin

Maybe only indigo. I've not tried with any other versions.

Then, also I found the vision_opencv package. Instead of ros-indigo-opencv3, is it better to replace opencv2 with vision_opencv? I'm not sure about these dependency and relations.

robograffitti avatar Jul 19 '16 06:07 robograffitti

The usual ROS recommendation for compatibility with multiple distributions is to depend on cv_bridge.

jack-oquin avatar Jul 19 '16 13:07 jack-oquin

That sounds make sense and I feel cv_bridge is the most popular package in the opencv related packages. Therefore, is it suitable to replace opencv2 with cv_bridge for this PR?

robograffitti avatar Jul 19 '16 15:07 robograffitti

Perhaps, although I am not certain. It would require testing on multiple distros.

jack-oquin avatar Jul 19 '16 15:07 jack-oquin