audio_common icon indicating copy to clipboard operation
audio_common copied to clipboard

Published 20 hours ago • verified publisher icon ros-drivers

Add EXTEND_EXISTING to allow sound_play to install msgs and python pkg

Open rolker opened this issue 11 months ago • 4 comments

This should solve #227 if the relavent PR to ament_cmake is accepted.

This depends on https://github.com/ament/ament_cmake/pull/517 being accepted.

rolker avatar Mar 07 '24 18:03 rolker

Converted to draft until dependent PR gets accepted.

rolker avatar Mar 07 '24 18:03 rolker

@rolker Thank you so much for the PR! I really appreciate your help, and I'm sorry that I couldn't work on the issue. I hope your PR will be merged soon

knorth55 avatar Mar 07 '24 19:03 knorth55

No need to be sorry, you did your part by submitting that initial PR yourself. I just pick up from that thread to try to get us all to a solution.

rolker avatar Mar 07 '24 19:03 rolker

@rolker I feel really sad that your PR got closed... https://github.com/ament/ament_cmake/pull/517 😢

knorth55 avatar Apr 11 '24 04:04 knorth55