audio_common icon indicating copy to clipboard operation
audio_common copied to clipboard

Published 20 hours ago • verified publisher icon ros-drivers

ROS2 migration?

Open airballking opened this issue 3 years ago • 10 comments

Dear maintainers of audio_common,

quick question: Are there any plans for migrating this package to ROS2?

If yes, what is the agenda? Do you need help from the community?

If no, what is the main reason? Potential reasons that I can come up with: Technical difficulty, exising (ROS2) alternative solution, or lack of resources.

Please consider also answering here: https://answers.ros.org/question/354035/audio_common-for-ros2/

Thanks a lot for your efforts and support! Georg.

airballking avatar Feb 02 '22 09:02 airballking

Currently no plan. It is better to migrate this package to ROS2, but I don't have enough time now. If someone cannot wait us and want to do it, I think it is better to have dicussion in a ROS discourse not ROS answers.

knorth55 avatar Feb 02 '22 10:02 knorth55

@airballking This is not related to audio_common, but are you using ROS2 in IAI bremen? Because you have PR2 (indigo?), how do you use ROS2? We have PR2 in our lab, and I want to know how you use ROS2 and PR2.

knorth55 avatar Feb 02 '22 10:02 knorth55

@knorth55 Thanks for the quick answer!

About using ROS2 on PR2: I am no longer working at IAI Bremen, but now head my own robotics startup in Bremen. In fact, we are a spin-off from IAI. So, if you are interested, then I can ask what the lab's progress is with using ROS2 on the robots.

About porting audio_common, I will first evaluate our needs (at the startup) regarding audio in ROS2. If we need, I can assign people to porting. But that will not before early March. Would you be available to support with advice regarding porting order and testing?

Best, Georg.

airballking avatar Feb 11 '22 15:02 airballking

@airballking I didn't know that you and Ferenc made a start-up. It is cool, i want to see your products in near future! I will ask PR2 upgrade to IAI by myself, thank you. Also, I can support or participate ROS2 porting, too!

knorth55 avatar Feb 14 '22 03:02 knorth55

I made a PR for this issue. #178 It is still WIP (mainly sound_play).

knorth55 avatar Feb 15 '22 17:02 knorth55

I made ROS2 branch, so please check it! https://github.com/ros-drivers/audio_common/tree/ros2

knorth55 avatar Feb 22 '22 15:02 knorth55

Hello, I am currently testing the ROS2 branch as I might need it in a project soon. The packages work well, however the "ns" no longer exists for "group" in the launch files. I switched it to "push-ros-namespace".

Patrick-AA avatar May 24 '22 15:05 Patrick-AA

@Patrick-AA thank you for your report. can you make a PR to ros2 branch?

knorth55 avatar May 24 '22 16:05 knorth55

Hi @knorth55, I only saw your February post on ros-answers today

I'm planning a development push to align https://github.com/BrettRD/ros-gst-bridge and https://github.com/clydemcqueen/gscam2 allowing video IO on composable nodes

gst_bridge supports audio very well now, and I'm interested in bringing some of that functionality to audio_common but I'm not sure where to start

BrettRD avatar Nov 11 '22 06:11 BrettRD

@BrettRD Thank you for your contribution! We are working on a development branch for ROS2, so please check this. https://github.com/ros-drivers/audio_common/tree/ros2

If you want to add new functions, please make a PR to ros2 branch.

knorth55 avatar Nov 11 '22 10:11 knorth55