ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

[ForceTorqueSensorBroadcaster] added force and torque offsets to the parameters + export state interfaces

Open saikishor opened this issue 1 year ago • 2 comments

This PR allows to define of the offsets of the force and torque through the parameter server. It would also be interesting to make it a chainable controller and expose the interfaces to the other controllers.

Now the offsets are removed and published and the same interfaces are exposed as state interfaces to be able to chain by other controllers

saikishor avatar Jul 17 '24 15:07 saikishor

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (7c89c17) to head (1f175ec). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...roadcaster/src/force_torque_sensor_broadcaster.cpp 91.30% 1 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   80.57%   80.68%   +0.11%     
==========================================
  Files         109      109              
  Lines        9553     9625      +72     
  Branches      832      841       +9     
==========================================
+ Hits         7697     7766      +69     
- Misses       1578     1579       +1     
- Partials      278      280       +2     
Flag Coverage Δ
unittests 80.68% <94.66%> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ster/test/test_force_torque_sensor_broadcaster.cpp 97.82% <100.00%> (+0.57%) :arrow_up:
...roadcaster/src/force_torque_sensor_broadcaster.cpp 89.21% <91.30%> (+2.77%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 17 '24 15:07 codecov[bot]

Rebased the PR! :)

saikishor avatar Sep 11 '24 18:09 saikishor