ElementHelper icon indicating copy to clipboard operation
ElementHelper copied to clipboard

Small Refactoring of Plugin

Open exside opened this issue 11 years ago • 3 comments

Nothing essential changed, basically preparing for bigger PRs coming (trying to split up https://github.com/roryg/ElementHelper/pull/16).

Adding functionality that clears the element helper cache when the cache is manually cleared by a member of an authorized user group via Top Menu > Clear Cache.

The big line changes in the main part of the plugin are not changes, it's just the indenting because of the switch statement! Nothing changed in the functionality!!

Integrated also the deprecated $modx->getMicrotime() fix from https://github.com/roryg/ElementHelper/pull/29

Following PRs will be based on this branch, so please merge this, then I can rebase my other branches with the new master of your repo, will make seeing changes easier!

exside avatar Sep 13 '14 13:09 exside

Thanks for this @exside!

I'm actually really close to getting the new version of ElementHelper into a releasable state. The new version has tidied up things a lot and will make the code much easier to work with (I hope!). I'll make an effort to get it up on a new branch in the next day or so with a list of things that are still left to do that I'd appreciate any help on.

roryg avatar Sep 14 '14 21:09 roryg

Sure, would love to have a look at =), let me know when the branch is up via comment here (then I get notified), yes?

exside avatar Sep 15 '14 10:09 exside

The branch is up now! (it's called 2.0) and I've started a new thread for it here https://github.com/roryg/ElementHelper/issues/31 with a link to a working package

roryg avatar Sep 15 '14 22:09 roryg