qcoder icon indicating copy to clipboard operation
qcoder copied to clipboard

Make nicer display of non edit view of document

Open elinw opened this issue 6 years ago • 3 comments

Right now we are using verbatim text and it's pretty ugly and unreadable. Switch to use html (will mean adding at least <p></p> tags and also consider converting QCODE tags to <mark></mark>. This is ideally a gsub use case I would think.

elinw avatar Jun 28 '18 20:06 elinw

I did the above and it looks much better #39 but it could definitely be improved upon by using multiple colors, doing something more complex with colors, doing something with the code strings ({}).

elinw avatar Jun 29 '18 21:06 elinw

@elinw There is actually a way to visualize and code highlight in the aceEditor (you basically make a set of rules for it to scan text for). It didn't look too difficult to build a code highlighter. I will take a look and see if I can implement it if that's of interest.

laderast avatar Nov 21 '18 04:11 laderast

I think it would be neat, when I’m in the editor I sometimes feel like it takes more scanning the text than it should to see where the codes start and end. (And what is or is not marked).

On Nov 20, 2018, at 11:16 PM, Ted Laderas [email protected] wrote:

@elinw https://github.com/elinw There is actually a way to visualize and code highlight in the aceEditor (you basically make a set of rules for it to scan text for). It didn't look too difficult to build a code highlighter. I will take a look and see if I can implement it if that's of interest.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropenscilabs/qcoder/issues/35#issuecomment-440524069, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEfQFZQ9upSsIGO0gvYH1-ZMXJIkVhks5uxNOogaJpZM4U7__e.

elinw avatar Nov 21 '18 04:11 elinw