webchem icon indicating copy to clipboard operation
webchem copied to clipboard

Published 20 hours ago • verified publisher icon ropensci

Increase test coverage

Open stitam opened this issue 4 years ago • 4 comments

webchem's test coverage has fallen lately. The rOpenSci policy is 75% so let's bring it up to at least 75%.

https://devguide.ropensci.org/building.html#testing

stitam avatar Sep 17 '20 16:09 stitam

What is the coverage when tests are run locally (i.e. ChemSpider is not skipped)? Might not be an issue, or might be a (somewhat) easy fix by adding a ChemSpider API token as a GitHub secret, then un-skipping those tests on CI.

Aariq avatar Sep 18 '20 17:09 Aariq

I might ask for some help there, if I run covr::package_coverage() from the dev directory, I get 0% for everything, I am clearly missing something. On the other hand, ChemSpider is skipped because of the missing token and Flavornet seems to be down.

stitam avatar Sep 21 '20 11:09 stitam

I can give it a try later this week.

Aariq avatar Sep 21 '20 12:09 Aariq

Local test coverage (with chemspider) is ~ 80%. But utils.R has lowest coverage, so boosting is probably a better idea than having chemspider tests run on CI.

Aariq avatar Sep 23 '20 14:09 Aariq